search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 120 forks source link

remove default implementation of `hasBasicAccess` to force organisations to specify in their implementation of `AuthorisationProvider` #4281

Closed twrichards closed 4 months ago

twrichards commented 4 months ago

Small follow-up to https://github.com/guardian/grid/pull/4271 to address https://github.com/guardian/grid/pull/4271#discussion_r1611906264 and force other organisations to specify in their implementation of AuthorisationProvider.

FYI @RichardLe (in your case I think you'll want to return true, given your single-sign on auth solution already controls basic access, by virtue of who's allowed in in the first place) CC @AndyKilmory @Conalb97

github-actions[bot] commented 4 months ago

Deploy build 12491 to TEST

All deployment options - [Deploy build 12491 to TEST](https://riffraff.gutools.co.uk/deployment/deployAgain?project=media-service%3A%3Agrid%3A%3Aall&build=12491&stage=TEST&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 12491 to TEST by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=media-service%3A%3Agrid%3A%3Aall&build=12491&stage=TEST&updateStrategy=MostlyHarmless)

From guardian/actions-riff-raff.

prout-bot commented 4 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 9 minutes and 40 seconds ago) Please check your changes!