guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.43k stars 119 forks source link

Adapt info panel height based on usePermissionsFilter config setting #4292

Closed AndyKilmory closed 1 week ago

AndyKilmory commented 1 week ago

The usePermissionsFilter kahuna config setting (true/false default:false) introduces a second tier top bar into the UI to hold the new permissions filter control (along other controls). When the second tier top bar is visible the height of the info-panel was found to be set incorrectly causing the lower section of the panel to be inaccessible (e.g. the keywords portion). This change corrects that fault by setting the height of the info-panel based on the presence of the second tier top bar

How should a reviewer test this change?

Ensure that the whole of the info-panel is visible and accessible when the second tier top bar is displayed and also ensure that the info-panel is vertically aligned correctly when the second tier top bar is not visible

Who should look at this?

Tested? Documented?

paperboyo commented 1 week ago

I can confirm this allows panel to be scrolled correctly. Thank for the fix!

image
prout-bot commented 1 week ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, collections, media-api, kahuna (created by @AndyKilmory and merged by @twrichards 8 minutes and 34 seconds ago) Please check your changes!

prout-bot commented 1 week ago

Seen on cropper (created by @AndyKilmory and merged by @twrichards 8 minutes and 38 seconds ago) Please check your changes!