search

guardian / gudocs

2 stars 1 forks source link

Snyk updates #53

Closed dskamiotis closed 1 year ago

dskamiotis commented 1 year ago

What does this change?

This PR aims to solve the Critical Snyk vulnerability for jsonpointer here

In order to do this some extra work was needed:

Also updated the REAME to include brew command to install redis

How to test

Follow README to run locally (ensuring to set up)

Deploy in order to get Snyk to test the dependancy vulnerability

How can we measure success?

Snyk vulnerability is not alerted

co-authored: @jonathonherbert

akash1810 commented 1 year ago

It looks like this hasn't been deployed to PROD. Is this known @dskamiotis @jonathonherbert? (cc @seanclarkeguardian)

akash1810 commented 1 year ago

It looks like this hasn't been deployed to PROD. Is this known @dskamiotis @jonathonherbert? (cc @seanclarkeguardian)

Update: Node 18 doesn't install on the server, for reasons similar to those reported on https://github.com/nvm-sh/nvm/issues/2142.

We'll revert this change (see #54).

This'll make Snyk unhappy, however as the changes on this branch are not deployed the reversion offers a truer reflection of the world.