search

guardian / gudocs

2 stars 1 forks source link

Update build tools, node and use Docker for local dev #63

Open phillipbarron opened 1 year ago

phillipbarron commented 1 year ago

What does this change?

Do not merge prior to a successful test in PROD

This PR reinstates the updates from this pr and further updates the build tooling

This change also updates Node to 16.20.0 & uses Docker for dev Redis rather than requiring it to be installed on the dev machine

How to test

Set up as per readme, check that changed can be views & published

How can we measure success?

Service still works and fewer Snyk vulnerabilities reported

Have we considered potential risks?

The deploy process for this service is manual and there is no code environment. This is far from ideal. Care should be taken in the review and deploy steps. We might consider updating the deploy process to use RiffRaff The build tooling is also an outlier (Using Grunt & Bower) - Moving to modern, supported tooling such as Webpack / Vite should be considered.

It may be a simpler task to rewrite as a couple of lambdas: one behind API gateway to serve the UI & a second running on a schedule to fetch doc changes 🤷 - this is, in general, not easy to work on.

arelra commented 4 months ago

Hi @davidfurey @phillipbarron would it be possible to resurrect this PR? Primarily interested in the dependency updates.

phillipbarron commented 4 months ago

Hi @davidfurey @phillipbarron would it be possible to resurrect this PR? Primarily interested in the dependency updates.

Possibly - I think there was some work underway to replace this entirely?