search

guardian / homebrew-devtools

A homebrew tap containing dev tools for the Guardian
2 stars 3 forks source link

Add thrift 0.9.3 Formula #14

Closed jorgeazevedo closed 6 years ago

jorgeazevedo commented 6 years ago

This formula for the legacy thrift version was last updated in Dec 2016, but apparently dropped from homebrew-core in 2017.

The iOS app is currently locked to version 0.9.3, as it's the last all obj-c thrift version. 0.10 and 0.11 use obj-c/swift 2, which our app project can't use because it's a swift 4 project.

https://github.com/Homebrew/homebrew-core/blob/9d524e4850651cfedd64bc0740f1379b533f607d/Formula/thrift.rb

shtukas commented 6 years ago

Looks good to me, but to be honest I have no idea how that kind of file works. So feel free to merge and if you need corrections apply them as needed :)

jorgeazevedo commented 6 years ago

Will do, thx!