search

guardian / homebrew-devtools

A homebrew tap containing dev tools for the Guardian
2 stars 3 forks source link

Fix ophan compilation issues by reverting to using Java 8 #43

Closed buck06191 closed 5 years ago

buck06191 commented 5 years ago

Change made in relation to https://github.com/guardian/homebrew-devtools/issues/42#issuecomment-539429576

Ophan was failing to compile locally using Java version 13. The compilation error type Generated is not a member of package javax.annotation was raised when compiling Scrooge from Twitter.

An issue raised on the scrooge repo https://github.com/twitter/scrooge/issues/299 deals with the same problem and was solved in that case by Twitter adding Java version 11 support if Scrooge version >=19.6.0 is used, which is something Ophan could do. However, Scala support for JDK11 is incomplete. See https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#jdk-11-compatibility-notes. With this in mind defaulting to OpenJDK8 is probably safer for the laptop setup script.

Testing was done locally by uninstalling java and then running 

brew cask install Casks/gu-base.rb
NataliaLKB commented 5 years ago

@buck06191 Can you merge this?