search

guardian / machine-images

DEPRECATED: Scripts for building machine images (principally AMIs)
34 stars 7 forks source link

Add SG parameter for Vulnerability Scanning #114

Closed adamnfish closed 8 years ago

adamnfish commented 8 years ago

There is now a vulnerability scanner in the Identity account. This PR lets us add a Security Group to instances to allow vulnerability scans.

The usefulness of this PR will depend to some extent on how widely used this is, since not all accounts have a scanner. Anyone that uses this or has an opinion, feel free to weigh in?

niklasvincent commented 8 years ago

👍

We should perhaps copy this entire Mongo template into the platform repo for Identity, given that the Mongo templates might change due to work by @jennysivapalan and Tools moving forward.

adamnfish commented 8 years ago

We decided adding this parameter to the shared template isn't the right approach. We'll instead add it to an ID-specific version of this CF.