At the moment, publishing content bumps the revision once for the published content, and twice for the draft content. This is because both the publish and update commands increment the revision number – the publish command passes an atom that's already been incremented into an update command.
This PR has the publish command delegate revision changes to the update action, and uses the output of the update action as the content to publish. As a result
How to test
On the main branch, running locally or in CODE, open the network tab and publish an atom, noting the revision number that comes back in the response – it's at contentChangeDetails.revision. Reload the page, and note that the revision number that comes back for the content is one greater.
Do the same on this branch. The revision numbers should match.
(There aren't any unit tests that cover DB behaviour that I can see 😢. But the change is fairly simple)
prout-bot
commented
1 year ago
What does this change?
At the moment, publishing content bumps the revision once for the published content, and twice for the draft content. This is because both the publish and update commands increment the revision number – the publish command passes an atom that's already been incremented into an update command.
This PR has the publish command delegate revision changes to the update action, and uses the output of the update action as the content to publish. As a result
How to test
mainbranch, running locally or in CODE, open the network tab and publish an atom, noting the revision number that comes back in the response – it's atcontentChangeDetails.revision. Reload the page, and note that the revision number that comes back for the content is one greater.(There aren't any unit tests that cover DB behaviour that I can see 😢. But the change is fairly simple)