guardian / media-atom-maker

A tool for creating media atoms, including a UI specifically for managing video
https://video.gutools.co.uk/videos
4 stars 3 forks source link

Add some user experience improvements to the uploads page #1155

Closed rhystmills closed 8 months ago

rhystmills commented 9 months ago

This PR fixes some bits of awkward functionality on the uploads page, specifically:

Before After
image image
Before After
image image
Before After
image image

How to test

This PR will be simpler to test on CODE because getting the end-to-end YouTube upload working locally will be complicated.

  1. Deploy this branch to CODE.
  2. Fill out the 'YouTube Furniture' without setting the Privacy status. This will let you check the validation is showing properly in the 'Edit Assets' page.
  3. Click the pencil icon in the top right, which shows a tolltip saying 'Edit Assets' on hover.
  4. Is there an explanation of why you can't upload a video? On hover, does the 'choose file' button under 'Upload to YouTube' remain the same colour?
  5. Go back to the YouTube furniture tab and add a privacy status, e.g. unlisted.
  6. Try uploading a .mp4 video. Are the Activate and Delete buttons disabled with a tooltip until the processing is done? Can you read the various messages shown while the processing takes place?
prout-bot commented 8 months ago

Seen on PROD (merged by @rhystmills 5 minutes and 18 seconds ago) Please check your changes!