guardian / media-atom-maker

A tool for creating media atoms, including a UI specifically for managing video
https://video.gutools.co.uk/videos
4 stars 3 forks source link

Add some user experience improvements to the uploads page (again) #1166

Closed rhystmills closed 5 months ago

rhystmills commented 5 months ago

Re-run of https://github.com/guardian/media-atom-maker/pull/1155 - without disabling the buttons. That PR was reverted because it inadvertently stopped users being able to activate YouTube live feeds, which media-atom-maker apparently supports.

The logic around this is not clear so I'm just going to introduce the more simple UI tweaks without touching this area. My guess is that YouTube live feeds never come out of the processing phase.

This PR fixes some bits of awkward functionality on the uploads page, specifically:

Before After
image image
Before After
image image
Before After
image image

How to test

This PR will be simpler to test on CODE because getting the end-to-end YouTube upload working locally will be complicated.

  1. Deploy this branch to CODE.
  2. Fill out the 'YouTube Furniture' without setting the Privacy status. This will let you check the validation is showing properly in the 'Edit Assets' page.
  3. Click the pencil icon in the top right, which shows a tolltip saying 'Edit Assets' on hover.
  4. Is there an explanation of why you can't upload a video? On hover, does the 'choose file' button under 'Upload to YouTube' remain the same colour?
  5. Go back to the YouTube furniture tab and add a privacy status, e.g. unlisted.
rhystmills commented 5 months ago

Something's gone horribly wrong with this branch, going to create a PR from a new one.