guardian / media-atom-maker

A tool for creating media atoms, including a UI specifically for managing video
https://video.gutools.co.uk/videos
4 stars 3 forks source link

Bump Node and some packages #1168

Closed rhystmills closed 4 months ago

rhystmills commented 4 months ago

What does this change?

This bumps Node and some packages to sort some client-side vulnerabilities in media-atom-maker. I've replaced the deprecated node-sass with sass (the former wasn't working for me with the newer node version, it might be an M1-related issue).

After bumping node, the ncc build command in 'pluto-message-ingestion' stopped working. Bumping some ncc-related packages seems to have fixed this, though I've had to move from inline CLI args to an ncc config file.

I had a pop at bumping webpack-dev-server, but it turned out to be a time-sink getting hot module loading working in v4, so I have rolled that back. The migration from v3 to v4 changes the conf structure in a lot of ways so I found it a bit complicated figuring out which change caused hot module loading not to work.

I'd be tempted to replace Webpack with Vite instead (as we did in Typerighter and facia-tool) so we have less conf and fewer loaders and plugins to maintain.

How to test

The version bumps are related to build tools or testing, so if the app builds, runs and tests it's probably good to go.

Run locally:

Does the app build and run as expected?

Run yarn test and yarn lint. Do those both work?