search

guardian / mobile-n10n

n10n for nOTIFICATIOn
Apache License 2.0
26 stars 4 forks source link

Play 3.0 upgrade #1214

Closed davidfurey closed 6 months ago

davidfurey commented 6 months ago

What does this change?

Minimal changes to upgrade to Play 3.0

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

github-actions[bot] commented 6 months ago

Deploy build 4310 of mobile-n10n:eventconsumer to CODE

All deployment options - [Deploy build 4310 of `mobile-n10n:eventconsumer` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Aeventconsumer&build=4310&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4310 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Aeventconsumer&build=4310&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Aeventconsumer&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4313 of mobile-n10n:schedule to CODE

All deployment options - [Deploy build 4313 of `mobile-n10n:schedule` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Aschedule&build=4313&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4313 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Aschedule&build=4313&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Aschedule&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4314 of mobile-n10n:football to CODE

All deployment options - [Deploy build 4314 of `mobile-n10n:football` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Afootball&build=4314&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4314 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Afootball&build=4314&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Afootball&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4311 of mobile-n10n:reportextractor to CODE

All deployment options - [Deploy build 4311 of `mobile-n10n:reportextractor` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Areportextractor&build=4311&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4311 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Areportextractor&build=4311&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Areportextractor&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4311 of mobile-n10n:fakebreakingnewslambda to CODE

All deployment options - [Deploy build 4311 of `mobile-n10n:fakebreakingnewslambda` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Afakebreakingnewslambda&build=4311&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4311 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Afakebreakingnewslambda&build=4311&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Afakebreakingnewslambda&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4310 of mobile-n10n:report to CODE

All deployment options - [Deploy build 4310 of `mobile-n10n:report` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Areport&build=4310&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4310 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Areport&build=4310&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Areport&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4319 of mobile-n10n:notification to CODE

All deployment options - [Deploy build 4319 of `mobile-n10n:notification` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Anotification&build=4319&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4319 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Anotification&build=4319&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Anotification&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4320 of mobile-n10n:slomonitor to CODE

All deployment options - [Deploy build 4320 of `mobile-n10n:slomonitor` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Aslomonitor&build=4320&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4320 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Aslomonitor&build=4320&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Aslomonitor&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4317 of mobile-n10n:registration to CODE

All deployment options - [Deploy build 4317 of `mobile-n10n:registration` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Aregistration&build=4317&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4317 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Aregistration&build=4317&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Aregistration&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 6 months ago

Deploy build 4366 of mobile-n10n:notificationworkerlambda to CODE

All deployment options - [Deploy build 4366 of `mobile-n10n:notificationworkerlambda` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=mobile-n10n%3Anotificationworkerlambda&build=4366&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 4366 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=mobile-n10n%3Anotificationworkerlambda&build=4366&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=mobile-n10n%3Anotificationworkerlambda&stage=CODE)

From guardian/actions-riff-raff.

davidfurey commented 6 months ago

Tests on Common and API-models haven't been run, and should be before this is merged

davidfurey commented 6 months ago

I have tested the latest snapshot and a test notification has been sent successfully.

It appears that we have to exclude com.typesafe.play bundles explicitly when the project depends on "ai.x" %% "play-json-extensions" (because it brings in the old play-json transitively). I am wondering whether we should also add the exclusion rule to the subproject notification, registration and report? Or have I missed anything (as the notification and registration API can work properly on CODE)?

You are correct, the exclusion should also be applied to notification, registration and report. I've pushed a commit with that

davidfurey commented 6 months ago

@waisingyiu do you think we have done sufficient testing to merge this?

waisingyiu commented 6 months ago

@waisingyiu do you think we have done sufficient testing to merge this?

Yes, I think the testing should be sufficient. I ran the following tests

I am happy to merge it and keep an eye on it tomorrow morning if it helps?

davidfurey commented 6 months ago

I am happy to merge it and keep an eye on it tomorrow morning if it helps?

That would be great, thanks!