search

guardian / mobile-notifications-content

Lambda that reads from the content api stream and triggers notifications for followable content
2 stars 0 forks source link

Update the sbt version #76

Closed lindseydew closed 3 months ago

lindseydew commented 3 months ago

What does this change?

This upgrades the version of sbt that we are building on

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

aracho1 commented 3 months ago

I deployed this to CODE for testing and created a CODE composer article. While the lambda logs&_a=(columns:!(),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,key:stage,negate:!f,params:(query:CODE),type:phrase),query:(match_phrase:(stage:CODE))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,key:app,negate:!f,params:(query:mobile-notifications-content),type:phrase),query:(match_phrase:(app:mobile-notifications-content)))),index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))) seem healthy, in the logs of the notification api&_a=(columns:!(message),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',key:app,negate:!f,params:(query:notification),type:phrase),query:(match_phrase:(app:notification))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',key:stage,negate:!f,params:(query:CODE),type:phrase),query:(match_phrase:(stage:CODE)))),grid:(),hideChart:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',interval:auto,query:(language:kuery,query:'%22Notification%20was%20sent%22'),sort:!(!('@timestamp',desc)))), I don't see an entry appear to validate that the publication event has been consumed by the lambda, as suggested by the README. As I'm not very familiar with this project, just wanted to double check if this is the expected behaviour?

lindseydew commented 3 months ago

I deployed this to CODE for testing and created a CODE composer article. While the lambda logs&_a=(columns:!(),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,key:stage,negate:!f,params:(query:CODE),type:phrase),query:(match_phrase:(stage:CODE))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,key:app,negate:!f,params:(query:mobile-notifications-content),type:phrase),query:(match_phrase:(app:mobile-notifications-content)))),index:b0be43a0-59d7-11e8-a75a-b7af20e8f748,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))) seem healthy, in the logs of the notification api&_a=(columns:!(message),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',key:app,negate:!f,params:(query:notification),type:phrase),query:(match_phrase:(app:notification))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',key:stage,negate:!f,params:(query:CODE),type:phrase),query:(match_phrase:(stage:CODE)))),grid:(),hideChart:!f,index:'26bd67e0-d55e-11e9-923e-49c5b785a0b2',interval:auto,query:(language:kuery,query:'%22Notification%20was%20sent%22'),sort:!(!('@timestamp',desc)))), I don't see an entry appear to validate that the publication event has been consumed by the lambda, as suggested by the README. As I'm not very familiar with this project, just wanted to double check if this is the expected behaviour?

Thank you for taking a look. Let's pair on testing this, and we can update the README with anything that wasn't immediately obvious.