search

guardian / path-manager

Service that manages paths for a domain. Ensures they are unique etc.
2 stars 0 forks source link

upgrade fiesta #32

Closed twrichards closed 4 years ago

twrichards commented 4 years ago

https://trello.com/c/jn7vNTvc/308-path-manager-upgrade-fiesta

What does this change?

https://github.com/guardian/path-manager/pull/29 was failing to deploy in CODE with silent errors (had to SSH onto the box to get the error), a Play upgrade was suggested so this is it, along with bumping everything to latest(ish)...

How to test

Run this branch in CODE (ideally - so you can test Metrics, Kinesis Logging etc.) and use Composer to create new headlines and change existing headlines - you should see entries in the logs&_a=(columns:!(message,level),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:a35a6090-59d7-11e8-bbe4-cbb5b151b19c,key:app,negate:!f,params:(query:path-manager),type:phrase,value:path-manager),query:(match:(app:(query:path-manager,type:phrase)))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:a35a6090-59d7-11e8-bbe4-cbb5b151b19c,key:stage,negate:!f,params:(query:CODE),type:phrase,value:CODE),query:(match:(stage:(query:CODE,type:phrase))))),index:a35a6090-59d7-11e8-bbe4-cbb5b151b19c,interval:auto,query:(language:kuery,query:'%22updated%20canonical%20path%22'),sort:!(!('@timestamp',desc)))) and Metrics in CloudWatch~(~'.~'pathUpdates~'.~'.~'.~'.~(color~'23ffbb78~yAxis~'right))~(~'...~'CODE~(color~'23aec7e8~yAxis~'left)))~view~'timeSeries~stacked~false~region~'eu-west-1~start~'-PT1H~end~'P0D~stat~'Sum~period~60);query=~'7bAppMetrics2cApp2cStage7d).

How can we measure success?

This brings things up to latest(ish) which is always good and also unblocks https://github.com/guardian/path-manager/pull/29 🎉

Have we considered potential risks?

There are some pretty big leaps in dependencies so there is some inherent risk in that (subtle behaviour changes), that said this is a fairly simple play app and everything seems to work in CODE. Would probably appreciate an explicit 👍 from @sihil before merging.

Images

fiesta

AWare commented 4 years ago

Is this runtime or compiletime DI?

twrichards commented 4 years ago

Is this runtime or compiletime DI?

@AWare it's compile-time (now at least - I eliminated all the @Injects that I introduced in the WIP commits)

I've tested it in CODE (including Logging and Metrics which had to change a bit).