search

guardian / path-manager

Service that manages paths for a domain. Ensures they are unique etc.
2 stars 0 forks source link

rename `lastModified` field (present on 'alias' PathRecords) to `ceasedToBeCanonicalAt` #47

Closed twrichards closed 3 years ago

twrichards commented 3 years ago

…to better represent what the timestamp means.

Related https://github.com/guardian/flexible-content/pull/3781 and https://github.com/guardian/flexible-model/pull/35

sihil commented 3 years ago

Are there going to be records in dynamo with lastModified set instead of the new name? Does it need a fallback on a read anywhere?

twrichards commented 3 years ago

Are there going to be records in dynamo with lastModified set instead of the new name? Does it need a fallback on a read anywhere?

There won't be in production, as they are only set on alias path records, none of which have been created in production yet. As for CODE, I don't think we need to worry about composer articles used for testing, we can just recreate.

We found out about the need for this just in time. I introduced lastModified (a few months back #38) simply for sorting the alias paths, turns out its useful in CAPI/Ophan so https://github.com/guardian/flexible-content/pull/3781 exposes it to CAPI.