search

guardian / prosemirror-noting

Prosemirror plugin that adds the ability to have ranges added to the document that expand and contract around dependent on the input.
MIT License
57 stars 8 forks source link

Get build working #55

Closed rhystmills closed 5 months ago

rhystmills commented 5 months ago

What does this change?

This makes a couple of changes to get yarn build working:

  1. Bumps Typescript - there's failures from recently bumped packages expecting a new version of Typescript
  2. Uses sass in place of node-sass. node-sass is deprecated and will not run on our M1 Macs, but is required by rollup-plugin-scss as a dev dependency. sass provides the same APIs as node-sass so rollup-plugin-scss will run using it.
  3. Bumps some other things which were not compatible with the newer version of Typescript

How to test

I've tested this locally by:

  1. Installing the most recently dependencies by running yarn
  2. Running yarn build and seeing the files build properly in /dist/
  3. Runing yalc publish and then adding to Composer locally with yalc add @guardian/prosemirror-noting, then updating the dependencies in the composer directory with npm i, then running ./dev-start.sh in the flexible-content repo root directory.