search

guardian / riff-raff

The Guardian's deployment platform
Apache License 2.0
266 stars 18 forks source link

fix: Report build number correctly #1275

Closed akash1810 closed 11 months ago

akash1810 commented 11 months ago

What does this change?

We're currently using the environment variable GITHUB_RUN_NUMBER to determine the build number for build info. GITHUB_RUN_NUMBER is not offset by the number of builds of this project previously performed by TeamCity.

This change creates a new environment variable BUILD_NUMBER which is GITHUB_RUN_NUMBER + the TeamCity offset.

The screenshot below taken from PROD, suggests we're running build 804, when in fact we are running build 3164 (804 + 2360).

image

When deployed to CODE, we get the correct number:

image

Builds on https://github.com/guardian/riff-raff/pull/1229. Inspired by https://github.com/guardian/flexible-content/pull/4382.

akash1810 commented 11 months ago

This is working as expected on PROD: image