search

guardian / salesforce-message-handler

Handle outbound messages from salesforce to update zuora and identity
0 stars 1 forks source link

Migrate to `scalaxb` for SOAP WSDL parsing #328

Closed rtyley closed 4 months ago

rtyley commented 4 months ago

As noted in https://github.com/guardian/salesforce-message-handler/issues/327, it looks likesalesforce-message-handler needs to drop sbt-cxf to work with versions of Java newer than Java 8 (the JAXB library is no longer a core part of Java).

This PR switches to scalaxb - it looks like a good replacement for sbt-cxf/wsdl2java, as it's maintained and has Scala-specific support: scalaxb Scala version support

The generated classes created by scalaxb are pretty similar to the ones generated by wsdl2java, there was just a small wrinkle with nillable id fields to deal with, which was fine.

tomrf1 commented 4 months ago

Wow, thank you @rtyley ! You've saved us a lot of time with this. We'll test this PR in CODE first

rtyley commented 4 months ago

We'll test this PR in CODE first

Thanks! Let me know if there's any problems 👍