search

guardian / scribe-plugin-noting

9 stars 3 forks source link

Updated ensure note integrity to place spacers correctly #100

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR ensures consistency with zero width space placing both within createNoteFromSelection and ensureNoteIntegrity. It also fixes the bug in which deleting the last space in a paragraph proceded by a completely noted paragraph removes the note.

noting-paragraph

This should be published before https://github.com/guardian/scribe-plugin-noting/pull/99 as this encapsulates the removal of zero width spaces within notes for multiple selectors.

hmgibson23 commented 9 years ago

Minor comment but :+1:

cutandpastey commented 9 years ago

Can i get some more eyes on this @robinedman @hmgibson23 @jamespamplin, there's been significant changes.

hmgibson23 commented 9 years ago

Looks good :+1:

robinedman commented 9 years ago

Good stuff :+1: