Dont delete zero width spaces

guardian / scribe-plugin-noting

9 stars 3 forks source link

Dont delete zero width spaces #106

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

Fixes https://github.com/guardian/scribe-plugin-noting/issues/103

QA

Place the caret at the end of a note
Press backspace
Ensure the last character within the note has been deleted and the zero width space has not
Place the caret just before a note
Press the delete key ( fn + backspace )
Ensure the first character of the note as been deleted and the zero width space has not

robinedman commented 9 years ago

What's supposed to happen when the zero width space at the start of the note is deleted? Edit: with backspace.

cutandpastey commented 9 years ago

@robinedman good point, maybe we should issue this?

cutandpastey commented 9 years ago

@robinedman Have tested this, don't think its more than a minor annoyance as ensureNoteIntegrity kicks in after you have deleted the space and re-inserts it.

cutandpastey commented 9 years ago

@robinedman fixed bugs we discussed.

cutandpastey commented 9 years ago

ping @robinedman

robinedman commented 9 years ago

Works fine in FF and Chrome and code looks good so :+1: !