search

guardian / scribe-plugin-noting

9 stars 3 forks source link

Bug fixes #132

Closed robinedman closed 9 years ago

robinedman commented 9 years ago

Fixes 2 noting bugs.

Bug 1: Can't expand note

To replicate you can for example do:

  1. Make some text bold.
  2. Create a note that starts before the bold text and ends after it.
  3. Collapse it.
  4. Try to expand it.

    Bug 2: Text is selected when expanding a note

To replicate: Try expanding a note. Either the whole or part of the note will be highlighted.

Bug 3: https://github.com/guardian/scribe-plugin-noting/issues/133

hmgibson23 commented 9 years ago

Nice fix :+1:

robinedman commented 9 years ago

I added the third bug fix to this PR

cutandpastey commented 9 years ago

:+1:

robinedman commented 9 years ago

Cheers! And tests pass so I'm merging this.