guardian / scribe-plugin-noting

9 stars 3 forks source link

Pasting a note between two paragraphs containing notes #163

Open shaundillon opened 7 years ago

shaundillon commented 7 years ago

To reproduce:

Effect: A new note is created from the start of the copied note, through to the end of the last note.

I've done some investigation into this and here are my findings: in generate-note-controller the isPasteInsideNote function checks if you're pasting content inside a note, and then calls wrap-in-note-around-paste if this is the case. This is incorrectly assuming you're pasting inside a note.

There is a branch with a scribe instance and noting set up here: https://github.com/guardian/scribe/tree/sd-fix-noting