search

guardian / scribe-plugin-noting

9 stars 3 forks source link

Add the ability to merge nodes that are next to each other #2

Closed hmgibson23 closed 10 years ago

hmgibson23 commented 10 years ago

When a new selection is next are to another one, we try to merge the nodes together, if a selection is in the middle of two notes then we can merge them all into one. Also the recursion had been replaced with a NodeIterator so that it uses the browser supported functionality. I've also remove the ridiculous thing of adding space on either side inside the span as this was a ridiculous solution and needs to be rethought

theefer commented 10 years ago

Merge conflict?

hmgibson23 commented 10 years ago

Woops, forgot to push

theefer commented 10 years ago

Do you think it'd be worth having tests for all of this? Quite worried that it's growing without any safety net.

rrees commented 10 years ago

I like some of the abstractions that are going on here.

hmgibson23 commented 10 years ago

SICP all the way