search

guardian / scribe-plugin-noting

9 stars 3 forks source link

added postinstall to build assets #24

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

Even tho we don't compile to UMD we should probably build out the assets so they can be required. If you don't want to do this then we should probably include the built assets in the src?

theefer commented 9 years ago

What's the scenario you envision where this is needed?

If someone installs from npm, they likely want to run from source (using deamdify or whatnot), rather than a pre-built version? We should just make sure that would work?

cutandpastey commented 9 years ago

Okay, I take your point. Looks like this plugin is written in cjs anyways so should just be a case of chaining the "main" field in the package