NPM harness

[cutandpastey]

I had some problems running the build because my global plumber is incompatible. Wrapping the test and build tasks with npm uses the local binaries which removes the issue. Ive also wrapped the setup.sh into a post install which means you only have to execute npm install to get up and running.

[rrees]

Makes sense to wrap as much of this as possible in npm :shipit:

[theefer]

Is it worth having a standard setup across plugins once it's proven to work?

[cutandpastey]

Yeah that would make sense. Whats the best way to template a plugin? grunt-init?:

https://github.com/gruntjs/grunt-init

[robinedman]

@theefer: Standard setup + a generator for a skeleton when you'd like to create a new plugin would be good (like we talked about this morning @cutandpastey).

[robinedman]

I'm happy for this to be merged once that one comment I made and @rrees comments are resolved :+1:

[cutandpastey]

After discussions with @rrees I've removed the need to download selenium to the vendor folder and replaced this with webdriver-manager. If someone could give this a whirl before merging, that would be great.

[robinedman]

I get:

~/projects/scribe-plugin-noting> npm test

> scribe-plugin-noting@0.2.13 test /Users/REdman/projects/scribe-plugin-noting
> npm run test-chrome

> scribe-plugin-noting@0.2.13 test-chrome /Users/REdman/projects/scribe-plugin-noting
> TEST_SERVER_PORT=9090 BROWSER_NAME='chrome' ./run-tests.sh

selenium standalone is up to date.
chromedriver is up to date.

/Users/REdman/projects/scribe-plugin-noting/node_modules/webdriver-manager/node_modules/adm-zip/zipFile.js:66
            throw Utils.Errors.INVALID_FORMAT;
                              ^
Invalid or unsupported zip format. No END header found

Seems to be something here about it: https://github.com/angular/protractor/issues/1005

[robinedman]

:+1: