search

guardian / scribe-plugin-noting

9 stars 3 forks source link

Refactoring Acceptance Tests #28

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

I found relating the acceptance tests to the spec we have here to be incredibly difficult. Also the organisation needed some work.

This PR adds missing coverage, abstracts helpers, re-organises the test structure and makes it a lot easier to both add more tests in the future and relate existing tests to the existing functional spec.

robinedman commented 9 years ago

Two very minor comments. Once sorted, :+1: This is much nicer, great work!