search

guardian / scribe-plugin-noting

9 stars 3 forks source link

Refactor Low Level Utilities #36

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR abstracts all low level utils from note-vdom, tests these utils and includes refactored methods.

QA

None really, everything should work as normal.

hmgibson23 commented 9 years ago

To make it easier to review, do you mind just pointing out which bits (if any) have made changes the to the logic of the original code? Also which bits might have cause issues in merging.

hmgibson23 commented 9 years ago

I won't comment on all the style issues as you have the style guide now!

hmgibson23 commented 9 years ago

:+1:

rrees commented 9 years ago

This PR is really too big to review properly. In future please try to drip feed changes like this through in pieces.