Fix note--collapsed add class bug + erroneous paragraph insertion

guardian / scribe-plugin-noting

9 stars 3 forks source link

Fix note--collapsed add class bug + erroneous paragraph insertion #38

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR fixes issues:

https://github.com/guardian/flexible-content/issues/1397 https://github.com/guardian/flexible-content/issues/1396

Tests have been written to cover the bugs.

Ive got a failing unit test which has been commented. I'll resolve this asap but it doesn't affect or cause issues relating to these fixes.

robinedman commented 9 years ago

Tested and works fine now. :+1:

I think since the refactoring there's some ambiguity about a "note" versus a "note segment". Both are now called "note". Might be good to think a bit about the naming to make it clearer.