Refactor note-toggle (part 2)

guardian / scribe-plugin-noting

9 stars 3 forks source link

Refactor note-toggle (part 2) #40

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR abstracts user data into a config object, adds a few helper utils and has moved create note at caret into its own module.

QA

Test creating new notes without a selection heavily

hmgibson23 commented 9 years ago

A few style issues and a merge conflict.

hmgibson23 commented 9 years ago

:+1:

robinedman commented 9 years ago

I'd still prefer to have findFirstNoteSegmentBelow and findFirstNoteSegmentAbove renamed as it's not really what they're doing (they're finding the next/previous note segment).

hmgibson23 commented 9 years ago

We should probably merge this though and release it as Jon's not here now until January.