Re virtual dom focus - Githubissues

robinedman commented 10 years ago

A new take on the noting functionality. Still a WIP.

What's new:

Virtual DOM and related libraries
Created a VFocus "class" which makes it possible to move around the Virtual DOM tree.
Integration tests.
The approach is different in the sense that we only ever wrap text nodes. This means we can do things in a more sequential way and care less about what the user has selected. One note is made up of one or more note tags. A note is defined as the sum of all note tags that are adjacent to each other (have abandoned ids since it's going to be more trouble than it's worth given our feature specs). The beginning and end of a note will be designated by a class or data attribute.

robinedman commented 10 years ago

@hmgibson23 @theefer Thanks for having a look at this rather extensive PR. :) Think I've dealt with your comments now. If you could have another look when you've got the time that'd be great!

To clarify, this is still a WIP -- something good enough for replacing the code that's currently live. I keep on working on what'll be the next PR (Trello card).

hmgibson23 commented 10 years ago

My main concerns were the window.getSelection and the removeScribeMarkers() duplication ... but they seem to have been addressed so :+1: from me

guardian / scribe-plugin-noting

Re virtual dom focus #6