Closed cutandpastey closed 9 years ago
Is this supposed to be a first step or a more complete "flag & correct" thing? Would help to know when reviewing it. If it's literally what the description says it looks good to me :) but otherwise I can immediately see some issues!
Such as:
Iv'e added tests and fixes for note collision, so if @robinedman is happy can we merge?
It's still possible to create a note within a flag and vice versa so I'm not sure if the collision stuff is working.
A couple of more things:
@robinedman note collision should now be fixed.
Can't test this atm. The build fix broke the build (https://github.com/guardian/scribe-plugin-noting/commit/10489c556148864a8ae071ab2b470dd6451cac36).
Now npm run build
doesn't build the JS anymore for some reason.
Fixed
Works really well now! :+1:
Cool, I'll wait for travis before releasing.
Im reverting this to get the fix for https://github.com/guardian/scribe-plugin-noting/issues/75 out
This PR adds the ability to construct notes of different tags i.e
<gu-flag></gu-flag>
.QA
Test all note functionality on the example page using F9, ensure
gu-flag
tags are constructed.