Toggle note tag names - Githubissues

guardian / scribe-plugin-noting

9 stars 3 forks source link

Toggle note tag names #74

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR adds the ability to click a note and toggle it's tag name i.e. gu-flag > gu-correct. This has to be configured during plugin init.

QA

Create a flag (F9), then click the give flag. The tag name should have changed to gu-correct.

robinedman commented 9 years ago

The code looks really good to me!

The problem I see is more of a usability thing (@alastairjardine?) : How do you "unnote" a correct? The only way I can see is to turn the correct into a flag (by clicking at the start/end or pressing F9) and then pressing F9 again.

alastairjardine commented 9 years ago

Cycling through seems sensible. F9 to add a flag, ⇧F9 to add a correct directly, F9 on correct to toggle to nothing?

robinedman commented 9 years ago

That sounds good I think. Easy to implement @cutandpastey ?

alastairjardine commented 9 years ago

It would have to maintain the selection so as not to be too annoying if the person removes the "correct" accidentally.

Or…⌥F9 to remove?

cutandpastey commented 9 years ago

You can only un-note something with the same key you use to create one. So for example a flag is F9 to create OR remove. I can add ⇧F9 to create or remove flag if you want?

hmgibson23 commented 9 years ago

:+1:

cutandpastey commented 9 years ago

Closing due to https://github.com/guardian/scribe-plugin-noting/pull/95