Fix collapse/expand all notes (within multiple scribe instances)

guardian / scribe-plugin-noting

9 stars 3 forks source link

Fix collapse/expand all notes (within multiple scribe instances) #83

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR fixes collapse/expand errors when notes are within multiple scribe instances. This is due to multiple events being registered to 'command:toggle:all-notes' which then register a change of noteCollapseState.

QA

Really difficult to achieve see: https://github.com/guardian/scribe-plugin-noting/issues/82

hmgibson23 commented 9 years ago

:+1: but the build failed but then it seems to fail all the time now.

cutandpastey commented 9 years ago

Yeah, looks like a Sauce Labs issue :( I'm just going to merge anyways.