Flag and Correct - Githubissues

guardian / scribe-plugin-noting

9 stars 3 forks source link

Flag and Correct #95

Closed cutandpastey closed 9 years ago

cutandpastey commented 9 years ago

This PR adds the ability to create flags and corrects.

flag-and-correct

QA

Create a note then try to create a flag within the note (F9). Ensure nothing is created.
Create a flag. Ensure a flag is created.
Click the created flag. Ensure it converts to a correct.
Try to create a note (F10). Ensure a note is not created.

hmgibson23 commented 9 years ago

Looks solid :+1:. Looking forward to QA-ing it.

cutandpastey commented 9 years ago

There's QA instructions at the top. You need to run http-server in the directory then go to http://127.0.0.1:8080/example/example.html ... Go Go Go!

cutandpastey commented 9 years ago

@robinedman Issues discussed should now be fixed.

robinedman commented 9 years ago

I've tried all kinds of funky stuff to break this. Works great! :+1:

screen shot 2015-02-11 at 14 32 41