search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Remove `clipboardData` polyfill #201

Open OliverJAsh opened 10 years ago

OliverJAsh commented 10 years ago

https://github.com/guardian/scribe/blob/818810f32054cbc573863af74f33c3b0b89d5e92/src/plugins/core/events.js#L224-266

Do we still need to support Firefox <=21?

When we don't, we can deprecate this.

TooTallNate commented 10 years ago

FWIW Firefox on Mac still needs this fallback.

TooTallNate commented 10 years ago

(though it's not even currently being applied since clipboardData is present, it just only contains "text" and no "html" entry)

TooTallNate commented 10 years ago

Though I would like to chime in and say that this is a good example of logic that could be extracted out into a standalone module. I've been noticing a lot of these cases in the scribe code base.

mikewnuk commented 10 years ago

Hey guys, pasting in Safari doesn't work from non-browser sources. For example, copy + pasting from Pages and TextEdit RTF doesn't work. clipboardData is present, but there is no text/html content type available. All formatting is lost.

OliverJAsh commented 10 years ago

Hey Michael. This sounds like a separate issue. Would you mind filing a new one for us, and we can discuss it there?

On Tuesday, July 29, 2014, Michael Wnuk notifications@github.com wrote:

Hey guys, pasting in Safari doesn't work from non-browser sources. For example, copy + pasting from Pages and TextEdit RTF doesn't work. clipboardData is present, but there is no text/html content type available. All formatting is lost.

— Reply to this email directly or view it on GitHub https://github.com/guardian/scribe/issues/201#issuecomment-50546284.

Oliver Joseph Ash Software Engineer

Visit theguardian.com. On your mobile and tablet, download the Guardian iPhone and Android apps theguardian.com/guardianapp and our tablet editions theguardian.com/editions. Save up to 57% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access. Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender and delete the e-mail and all attachments immediately. Do not disclose the contents to another person. You may not use the information for any purpose, or store, or copy, it in any way. Guardian News & Media Limited is not liable for any computer viruses or other material transmitted with or as part of this e-mail. You should employ virus checking software.

Guardian News & Media Limited is a member of Guardian Media Group plc. Registered Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP. Registered in England Number 908396