search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Release script: Bump version in package.json #205

Open OliverJAsh opened 10 years ago

hmgibson23 commented 10 years ago

This is done now. So I guess this can be closed?

hmgibson23 commented 10 years ago

Just realised my mistake ... release.sh only does bower.json

OliverJAsh commented 10 years ago

Yeah, we've automated the Bower release, but not npm: https://github.com/guardian/scribe/blob/master/CONTRIBUTING.md#npm

hmgibson23 commented 10 years ago

This pull should deal with this: https://github.com/guardian/scribe/pull/228

rrees commented 10 years ago

@hmgibson23 It looks mversion should be able to write to package.json as well. Was there an issue with it?

hmgibson23 commented 10 years ago

So it looks like this issue https://github.com/mikaelbr/mversion/issues/12 and the subsequent pull request has made it possible to specify the file. I think we could merge the scripts now. It should be a pretty simple change.

theefer commented 10 years ago

One thing to remember is that package.json is in master only, but bower.json is in both master and dist.

Visit theguardian.com. On your mobile and tablet, download the Guardian iPhone and Android apps theguardian.com/guardianapp and our tablet editions theguardian.com/editions. Save up to 57% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access. Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender and delete the e-mail and all attachments immediately. Do not disclose the contents to another person. You may not use the information for any purpose, or store, or copy, it in any way. Guardian News & Media Limited is not liable for any computer viruses or other material transmitted with or as part of this e-mail. You should employ virus checking software.

Guardian News & Media Limited is a member of Guardian Media Group plc. Registered Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP. Registered in England Number 908396