search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Enable scribe to work in iframes #216

Closed daniel-nelson closed 9 years ago

bradvogel commented 10 years ago

Why not derive the targetWindow from the element? E.g.

scribe.el.ownerDocument.defaultView
daniel-nelson commented 10 years ago

I considered that after @TooTallNate recommended it, but part of the reason for this commit is to accommodate unforeseen use cases of Scribe. What if a use case applied Scribe to a detached element? There wouldn't be a document. Rather than add more complexity to handle that case, I thought it better to just leave the decision to the developer. But I could certainly adjust it to auto-compute.

bradvogel commented 10 years ago

Yeah, perhaps adjust to autocompute if targetWindow isn't provided.

OliverJAsh commented 10 years ago

Merge conflict!

daniel-nelson commented 10 years ago

@OliverJAsh resolved conflict

hmgibson23 commented 10 years ago

Another merge conflict. Also is this just bundle in your latest pull request? It looks like it. Please see the comments on that one