search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Allow entering multiple consecutive spaces #232

Closed metadoggo closed 10 years ago

metadoggo commented 10 years ago

The behaviour has been changed to allow multiple consecutive spaces to be entered, they are only removed when .getContent() is called (when the content is saved to the server). This also allows spaces to be entered into new paragraphs.

Note: This could be a breaking change for some people.

theefer commented 10 years ago

Could there be a test for this? Just putting content with nbsp in Scribe and taking it out?

OliverJAsh commented 10 years ago

Should we test that they don't get removed when you type normally?

OliverJAsh commented 10 years ago

I thought we were going to remove this formatter from core?

OliverJAsh commented 10 years ago

@hmgibson23 @riiibs I think this will address several issues. I'll try to dig them out – it would be good to verify whether they are fixed now, and if so we can close them.

hmgibson23 commented 10 years ago

I think it will. Should fix this issue: https://github.com/guardian/scribe/issues/229. I'll have a look for others

OliverJAsh commented 10 years ago

https://github.com/guardian/scribe/issues/200 https://github.com/guardian/scribe/issues/229