search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Add test for tables fix. #244

Closed bradvogel closed 10 years ago

bradvogel commented 10 years ago

Requires https://github.com/guardian/scribe-common/pull/6. Fixes https://github.com/guardian/scribe/issues/243.

This is my first time contributing to Scribe. I assume we need to merge https://github.com/guardian/scribe-common/pull/6 and republish to Bower before merging this.

hmgibson23 commented 10 years ago

This looks good to me. Please check the contributing file to check everything. The release can be done by me or someone else. :+1:

bradvogel commented 10 years ago

Ok, double checked. https://github.com/guardian/scribe-common/pull/6 needs to be merged and released though.

hmgibson23 commented 10 years ago

Okay great. I'll do a release for both common and scribe tomorrow to get your changes in.