search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Update scribe plugins. #245

Closed bradvogel closed 10 years ago

bradvogel commented 10 years ago

scribe-plugin-curly-quotes 0.1.7 scribe-plugin-smart-lists 0.1.4

hmgibson23 commented 10 years ago

I think you've accidentally added all the bower components. These should be in https://github.com/guardian/scribe/blob/master/.gitignore, so could you get rid of them?

bradvogel commented 10 years ago

Yes, I also thought it was odd - I was just following what was done before, e.g. https://github.com/guardian/scribe/commit/22bead35d7e8dd6ceda3fc38a3cf05145cc208a6

Updated to add bower_components to gitignore (like what was done in master).

hmgibson23 commented 10 years ago

Sorry. I was looking at the wrong branch! I thought this was going to master. We do actually need the bower_components in this branch as this is what goes on Github. If you undo your previous commit I'll happily merge this in.

bradvogel commented 10 years ago

Ok done.

hmgibson23 commented 10 years ago

Great. Thank :+1: