search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Do not insert BR in empty inline elements when parent node contains text #258

Closed AleLudovici closed 9 years ago

AleLudovici commented 9 years ago

This solves the bug shown in the gif... bold_space_bug

and the fix.... bold_space_fix

AleLudovici commented 9 years ago

Scibe-common updated to use isCaretPositionNode. We also use !isBlockElement as suggested.

hmgibson23 commented 9 years ago

@robinedman. Mind taking a look?

On 2 October 2014 10:05, Alessandro Ludovici notifications@github.com wrote:

Scibe-common updated to use isCaretPositionNode. We also use !isBlockElement as suggested.

— Reply to this email directly or view it on GitHub https://github.com/guardian/scribe/pull/258#issuecomment-57601720.

Visit theguardian.com. On your mobile and tablet, download the Guardian iPhone and Android apps theguardian.com/guardianapp and our tablet editions theguardian.com/editions. Save up to 57% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access. Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender and delete the e-mail and all attachments immediately. Do not disclose the contents to another person. You may not use the information for any purpose, or store, or copy, it in any way. Guardian News & Media Limited is not liable for any computer viruses or other material transmitted with or as part of this e-mail. You should employ virus checking software.

Guardian News & Media Limited is a member of Guardian Media Group plc. Registered Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP. Registered in England Number 908396

robinedman commented 9 years ago

Sure thing. I'll pull and have a play around with this one! :)

robinedman commented 9 years ago

Seems to be working fine (also for custom elements like <gu-note>, wohoo! ). And integration tests are passing. :+1: