search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Rework mandatory plugin loading #275

Closed rrees closed 9 years ago

rrees commented 9 years ago

As discussed with Hugo there's a question about whether we should be loading plugins or commands at all here but I've tried to make it easier to see what is happening and to add new mandatory plugins.

Apologies for the explicit loops, I might try and fix that at some point. forEach failed the tests.

hmgibson23 commented 9 years ago

I think this is a good idea personally. Not sure how @theefer feels about this. But it does seem right that all plugins are optional.

theefer commented 9 years ago

All patches should surely be loaded? If you mean commands, they could be option if it's not a feature accessible natively, and assume the user would add the command if they add support for it (e.g. via toolbar, shortcut, etc). Is undo/redo accessible with shortcuts though?

hmgibson23 commented 9 years ago

Sorry. Yeah patches should be loaded. That makes sense with commands. Undo/redo is definitely accessible in Chrome - it might not be in Firefox.

theefer commented 9 years ago

:+1:

hmgibson23 commented 9 years ago

Looks good :+1: