search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Spellcheck underline comes up in the middle of typing a word #298

Open bradvogel opened 9 years ago

bradvogel commented 9 years ago

When typing in the scribe basic example (http://guardian.github.io/scribe/) in Firefox, the spellcheck red underline appears when I'm in the middle of typing a word. The default contenteditable behavior is to wait to check spelling until I enter a space.

In Chrome it only happens when typing in a paragraph that isn't the last one. To repro this on http://guardian.github.io/scribe/, add a new line before "Hello World!" and start typing a word.

It doesn't appear to happen in Safari.

bradvogel commented 9 years ago

It appears to be caused by running the transaction manager (and placing markers) on every keystroke. So this will likely be mitigated by https://github.com/guardian/scribe/issues/98.

hmgibson23 commented 9 years ago

Thanks for pointing this out. You're right it probably will be fixed by https://github.com/guardian/scribe/issues/98, although I'm not sure much progress on that is being made.