search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Running Sauce JS tests on pull requests #304

Closed cvrebert closed 9 years ago

cvrebert commented 9 years ago

So, I notice that Scribe uses Sauce Labs for real-browser JS testing. I was wondering whether you'd be interested in enabling Sauce testing for pull requests too (while still keeping your Sauce credentials secure)? If so, you might be interested in the tool we created to do this for Bootstrap: Savage: https://github.com/twbs/savage

If there's interest, I would be more than happy to assist you in setting up a Savage instance for Scribe.

hmgibson23 commented 9 years ago

I think there would be interest. We certainly need to do something about foreign PRs, as they always fail. \ccing @rrees as he's been handling our testing stuff.

rrees commented 9 years ago

@cvrebert It definitely fixes a problem for us, I've taken a brief look at the requirements, I'm not sure we necessarily value this enough to run a server that costs. Will something like Heroku be suitable?

cvrebert commented 9 years ago

Not Heroku in particular, since its free tier doesn't include any writable filesystem storage (Savage needs a local clone of your git repo to pull-to/push-from).

For comparison, I happen to run Bootstrap's Savage instance on DigitalOcean's cheapest $5/month VM.

Savage doesn't need a server all to itself though; should be able to run it alongside other stuff with just a little extra configuration.

rrees commented 9 years ago

@cvrebert Thanks for the update. I don't feel this problem badly enough to want to admin a server for it. If someone else from the team is up for tackling it we can give it a go. Otherwise I might investigate whether there is a suitable platform for running the server.