guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

API: use the Scribe root element to stop DOM traversal #331

Closed rrees closed 9 years ago

rrees commented 9 years ago

This picks up #308 and tries to use the element that the Scribe instance is bound to determine whether the searched element is at the root or not.

I'm not sure how much I trust the test suite on this but things are not broken ™

hmgibson23 commented 9 years ago

LGTM :+1:

rrees commented 9 years ago

@hmgibson23 I'll merge tomorrow morning, I'm not sure I've got time to do the full release process now