guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Add additional function arguments to document.createTreeWalker calls #333

Closed deains closed 9 years ago

deains commented 9 years ago

This is a small fix for IE compatibility. IE doesn't consider the arguments to createTreeWalker optional, so it bombs out if any are missing. This is causing observeDomChanges to break in IE11, and may well be breaking other stuff too.

Adding in the arguments with their default values should not cause any compatibility issues with other browsers.

See here for reference: https://developer.mozilla.org/en-US/docs/Web/API/Document.createTreeWalker

hmgibson23 commented 9 years ago

Looks fins to me :+1: