Observing 'attributes' is unnecessary

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform

http://guardian.github.io/scribe/

Apache License 2.0

3.51k stars 245 forks source link

Observing 'attributes' is unnecessary #382

Closed bradvogel closed 9 years ago

bradvogel commented 9 years ago

Observing 'attributes' is actually unnecessary since all mutations that don't add or remove DOM nodes are filtered out anyways. See includeRealMutations. This will increase performance a bit.

hmgibson23 commented 9 years ago

Makes sense to me :+1:

bradvogel commented 9 years ago

The build is failing. Is that expected?

bradvogel commented 9 years ago

Bump @hmgibson23

hmgibson23 commented 9 years ago

Yeah build always fails from foreign PRs ... sorry this slipped away from me. I'll check and merge today.