Faster selection api - Githubissues

regiskuckaertz commented 9 years ago

Removed unnecessary dependency on AMD module element (already available in scribe)
Moved the rootDoc selection out of the constructor so that it is executed only once (per Scribe instance)
Used compareDocumentPosition to detect if scribe.el is in a fragment, and only then look for that fragment
Moved redundant code in small, optimizable functions createMaker and insertMarker
Replaced range arithmetic with simpler node comparisons
Replaced Element.offsetParent test with document.contains, more accurate
Overall simpler placeMarker implementation will less transient variables
Faster implementation of isEmtpyInlineElement (moved to node.js for consistency)
Moved scribe.node and scribe.element up in the prototype chain so they're assigned at parse time

rrees commented 9 years ago

Looks good to me but I think I'd like a second-pair of eyes :+1:

hmgibson23 commented 9 years ago

Looks good :+1:

guardian / scribe