search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Consolidating node operations #397

Closed regiskuckaertz closed 8 years ago

regiskuckaertz commented 9 years ago

Hello,

Right now DOM-related operations are scattered all over: in ./node.js, ./element.js, ./api/node.js, ./api/children.js and sometimes in core plugins (think unwrap, insertAfter, hasContent, etc.). Plus ./api/node.js defines a class with a link to a DOM node: this can be a source of memory leaks if objects are never released (in closures for instance).

I could survey the code, make an inventory of all DOM-related operations and put everything into a single AMD module (./node.js). This would increase consistency, remove redundant code, which means more optimized code and an overall happier browser :-)

How does that sound?

hmgibson23 commented 9 years ago

Sounds good to me!

regiskuckaertz commented 9 years ago

@hmgibson23 great! I'm on it.

regiskuckaertz commented 9 years ago

This is going to be a biggie, I'll split this into multiple PRs for everyone's sake :-)

rrees commented 9 years ago

Are we okay to close this one now?

regiskuckaertz commented 9 years ago

Yes of course.