search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

ImmutableJS version #400

Closed Carlsson87 closed 9 years ago

Carlsson87 commented 9 years ago

scribe-editor is currently depending on version ~3.6.2 of ImmutableJS, which results in version 3.6.4.

On line 11 in src/element.js the method includes of ImmutableJS's Set is used. This method does not exist in any 3.6.* version, it was added in 3.7.1.

Either require a more recent version of Immutable, or use it's alias contains.

Related issue on their repo: https://github.com/facebook/immutable-js/issues/499

regiskuckaertz commented 9 years ago

+1 saw that too yesterday

rrees commented 9 years ago

Yes, this was updated in Bower but not in the NPM dependencies

rrees commented 9 years ago

Published v1.4.5 which should be in sync, @Carlsson87 can you check?

Carlsson87 commented 9 years ago

Perfect. Good job.